195 karma · joined July 27, 2013
JavaScript is not their biggest problem, as they can plug in one of the existing engines (in fact one of the links forks does just that).
Also, enable "Run mpv in its own window" under Preferences -> Advanced. This removes all the issues caused by the default mode of embedding the mpv window (such as subtitles being on the video and not in the black bars).
Thank you for your work on mpv!
A possible solution: https://github.com/thredded/thredded/pull/525
What do you think?
> It has a lot of whitespace [...]
Whitespace can be reduced across the board by adjusting a variable:
https://github.com/thredded/thredded/blob/1a60bcc7618270afeb...
For the homepage, I'm going to try removing the vertical spacing between the cards.
> on a desktop [...] maybe put the name besides the post instead of on top
Definitely going to try that!
> A lot of elements have dynamic positions (e.g. the date, the author) which makes it quite hard to quickly scan the overviews for them.
I didn't realize there is a use-case for scanning through these. No good ideas yet on how to improve this.
> Image support?
By default only externally referenced images are supported, but integrating with third-party uploading services is easy. For example, here is how to do it with Shubox.io:
1. Client-side performance. Little JavaScript and lean CSS. Even the KaTeX math plugin renders math server-side.
2. Clean but discoverable UI. The focus is content. Not a single dropdown nor a hamburger menu.
3. Extensible, but critical features are built-in to provide a foundation for plugins. Features such as notifications, moderation, permissions system, and full text search.
4. Pleasant on mobile for both browsing and content creation. This means a textarea instead of a rich text editor (by default).
5. Everything degrades gracefully when JavaScript is off. For example, preview-as-you-type becomes a "Preview" button if JavaScript is disabled.
6. The relational database for everything, including full text search. Data integrity is easy, no out-of-sync elasticsearch databases here. Runs on Postgres, MySQL, and SQLite.
Boring technology => easy to deploy and run in production.
The codebase is written in Ruby, has slowly developed over the years, and has extensive test coverage.
I am very curious to hear what you think, and whether you've ever felt a need for a forum like that.
Such issues are rarely style issues. They are more in the design territory where the focus of code reviews should be.
In the long run improving the linter is better for everyone. The examples given by the OP as infeasible are feasible.
Focus on the design over trivial style issues. Your style guide should be 95% covered by the linter. If it isn't, fix your linter.
> Broadly missing a point
My points is: Underestimating static analysis will lead you to the wrong conclusions.
Both of these (if vs guard clause, loop vs each) are enforced by the Rubocop linter in Ruby.
Exactly this. It is still faster to build websites with Rails, mainly thanks to the maturity of the ecosystem, so I still use it when render-HTML-on-the-server fits the bill. And Turbolinks 5 is surprisingly snappy, here is a demo of a forums site that I've just deployed running vanilla Turbolinks 5: https://thredded.org/.
i18n-tasks is on the command line, easily extensible, with configuration that can be easily tailored to the app from data layer to usage search. It is also very easy to integrate it into the test suite.
The default data adapter supports YAML and JSON by default, more common in many web communities (rails, node) than .po.